Re: [O] [patch] Improved block insertion

[Rasmus]

Hi,

Thanks for the comments!

I have fixed up the patches.  

> I don't think the old key-binding should be kept.

OK.

> Suggestion:
>
>   (key (pcase (read-char-exclusive prompt)
>         ((or ?\s ?\t ?\r) ?\t)
>         (char char)))


Ha, actually I used pcase at first but then changed it to something more
simple.  Are there any performance issues with pcase or can it be used
unconditionally?

>> +    (let ((menu-choice (org--insert-structure-template-mks)))
>> +      (if (equal (nth 0 menu-choice) "\t")
>> +      (read-string "Structure type: ")
>> +    (nth 1 menu-choice)))))
>
> (pcase (org--insert-structure-template-mks)
>   (`("\t" . ,_) (read-string "Structure type: "))
>   (`(,_ ,choice . ,_) choice))

Thanks, that’s nice. 

Any worries about pushing the patches now?

Rasmus

-- 
I hear there's rumors on the, uh, Internets. . .

0001-org-macs-Move-org-mks-from-org-capture-to-org-macs.patch
Description: Text Data

0002-org-macs-Make-tab-space-and-RET-equivalent-in-org-mk.patch
Description: Text Data

0003-org-org-structure-template-alist-uses-string-keys.patch
Description: Text Data

0004-org-tempo-Various-improvements.patch
Description: Text Data

0005-org-Change-structure-insertion.patch
Description: Text Data

0006-org-Change-org-insert-structure-template-to-C-c-C.patch
Description: Text Data