emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Adding single cell movement to org-table


From: Chris Kauffman
Subject: Re: [O] Adding single cell movement to org-table
Date: Tue, 29 May 2018 15:29:43 -0500

All- 

Attached are the updated patches for single cell movement in org tables.

Notes:
- Implemented all of Nicolas Goaziou's suggestions on this with some caveats described below

- Part of the logic of the code requires boundary checking. I used the (org-table-analyze) to set variables org-table-current-ncol and org-table-dlines which are the limits of the table. This eliminated an internal helper function in the original version.

- I made several of the functions internal with the naming convention `org-table--name' as per Nicolas' suggestion

- Checks for in-table and table alignment are in the top-level functions `org-table-move-single-cell-up' etc.; I kept alignment in as otherwise the table looks awful as cells move around

- Modified org.el to bind these to Shift-up and the like as per Carsten's suggestion

- Tests defined in testing/lisp/org-test-table.el and I've done a fair amount of interactive testing to ensure the behavior looks correct.

- Not sure if the patches will work exactly correctly due to the large gap in time between my initial work and completion; let me know if things don't look correct.

- Attempted to get close to a correctly formatted commit messages but do make any necessary formatting changes for compliance.

Cheers,
Chris Kauffman

On Fri, May 4, 2018 at 7:18 PM, stardiviner <address@hidden> wrote:
That's really great. Thanks.

--
[ stardiviner ] don't need to convince with trends.
       Blog: https://secure-web.cisco.com/1hJRqsuxlpwmP971H8dAeGulRNSKNY87qhElIE0kGFNVU8wi5u2jTzEhayLSBa8GhYPZPyxSM3aWcEqi0yTtMPyedBey2od2ROikNbAYTnTptEFLNGp6HovNx1ukbSykVmN4jthKPhqhL-zPqBtiblX6c8EibrNqBfI2YR_DfuTSNew8YeBmyRu0Mr_et5PfrTaMoyrIurSC1ogXRXRMh8ds6CXnNjU7bhWZeOcjRQfyLbssZQ-zuRp5pSm2JMyC0h7QmqikJC6pNGBrSYPaxd37aLkMNyqhF6LyEpq2LrpWkms4s56sq9R4_MUrvT16dpqMPPcp1pfA1DAaPt0DBOlZIDWuieyVZSmscuGyWN6hhiYyTc0EY-_iwmxe0UCfRK4t0adbHcAj0cYCdGjgliGOk9jHInQTGngBOSNT_htY/https%3A%2F%2Fstardiviner.github.io%2F
       IRC(freenode): stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3



Attachment: 0001-org-table-Adding-single-cell-movement-functions-and-.patch
Description: Text Data

Attachment: 0002-Added-keybindings-for-org-table-move-single-cell-fun.patch
Description: Text Data

Attachment: 0003-Updates-to-ORG-NEWS-describing-single-cell-movement-.patch
Description: Text Data

Attachment: 0004-Modified-org.texi-to-include-documentation-of-single.patch
Description: Text Data

Attachment: 0005-Modified-orgguide.texi-to-include-documentation-of-s.patch
Description: Text Data

Attachment: 0006-Code-changes-for-single-cell-movement-with-notes.patch
Description: Text Data

Attachment: 0007-org-table.el-Added-single-cell-movement.patch
Description: Text Data

Attachment: 0008-org-table.el-added-single-cell-movement.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]