[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Add :target option for the TOC keyword

From: Nicolas Goaziou
Subject: Re: [O] [PATCH] Add :target option for the TOC keyword
Date: Tue, 21 May 2019 21:43:12 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)


Sacha Chua <address@hidden> writes:

> Hi! Here's a patch to allow table of contents to target a specified
> headline. I've added tests for HTML, ASCII, Markdown, and ODT export.
> I should have copyright assignment papers already on file.
> Does it work for anyone other than me? =)

Thank you! I cannot guess the use case, but you certainly have one :)

Even if this doesn't sound like a very common need, it doesn't add too
much overhead to the code base either. It would be nice if it really
generalized "local" keyword, i.e., with ":target local", "local" variant
being supported but not documented.

Also, there seems to be much code duplication in the export back-ends.
Would it make sense to factor this out into a function in "ox.el". For
example, `org-export-resolve-link-string' or some such? With some tests
for bonus points.

Speaking of tests, we usually don't write tests for export back-ends, so
you can drop them.

Could you send an updated patch?


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]