[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] restore window configuration after org-edit-src-exit

From: Jack Kamm
Subject: Re: [PATCH] restore window configuration after org-edit-src-exit
Date: Thu, 09 Jan 2020 09:43:41 -0800


Nicolas Goaziou <address@hidden> writes:

> Thank you for the patch! Some comments follow.
> It would be useful to also explain what happens when the value is
> `reorganize-frame', `split-window-right', or `split-window-right', e.g.,
> that previous window configuration is restored.
> It may be useful to wrap `set-window-configuration' within
> `unwind-protect' so we can still reset the
> `org-src--saved-temp-window-config' variable even though something went
> wrong.

Thank you for reviewing my patch, I agree with both of your suggestions,
and have added them to the attached patch, which I also rebased on
latest master.

I am wondering whether this should be considered a new feature, or
instead fixing a regression, in which case I could rebase on maint

Finally, I think we should consider moving to the display-buffer
as this will provide a lot more flexibility, and simplify the code as
well. We could also use `quit-restore-window'
to restore the window configuration after editing. I'll start a new
thread/RFC/patch for this later this month, when I have a bit more time.

Attachment: 0001-org-src-restore-windows-for-some-values-of-org-src-w.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]