[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [QUESTION] A decision about matching ob-sql.el's :engine header argu

From: Tim Cross
Subject: Re: [QUESTION] A decision about matching ob-sql.el's :engine header argument match sql-mode product name
Date: Thu, 30 Jan 2020 18:29:53 +1100
User-agent: mu4e 1.3.7; emacs 27.0.60

My vote would be to modify ob-sql and change the hard coded values into
a custom variable. Then users can add/remove/modify engine names to suit
their requirements. The default should probably match the product names
supported by sql.el (you could even have multiple entries mapping to the
same product name for backwards compatibility i.e. 'postgres' =>
'postgres', 'postgresql' => 'postgres' etc.). It would also be trivial
to then add new 'products' in the future.

stardiviner <address@hidden> writes:

> I'm writing a patch which try to set ~sql-product~ when editing sql src block.
> Here is the code:
> #+begin_src emacs-lisp
> (defun org-babel-edit-prep:sql (info)
>   "Set `sql-product' in Org edit buffer.
> Set `sql-product' in Org edit buffer according to the
> corresponding :engine source block header argument."
>   (let ((product (cdr (assq :engine (nth 2 info)))))
>     (sql-set-product product)))
> #+end_src
> But =ob-sql.el= source code hardcoded ~:engine~ names which some are not 
> matched
> with ~sql-product-alist~ in =sql-mode=. For example =:engine postgresql=, but 
> it's
> ~postgres~ in ~sql-product-alist~.
> For now, I have two solutions:
> 1. write an adapter function which translate ~:engine~ header argument value 
> into
>    ~sql-product-alist~ product names. This is a safe way, which will not
>    incompatiable with old Org document.
> 2. modify source code hardcoded ~:engine~ names (also need to update Org
>    document), this has a minor advantage is *consistance*.
> BTW, about writing an adapter function to translate names. I want to hear some
> suggestion about use which method. Writing an hash map or assoc list etc?
> Regards

Tim Cross

reply via email to

[Prev in Thread] Current Thread [Next in Thread]