emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix ob-python.el initiate session error with py-shell


From: Bastien
Subject: Re: [PATCH] Fix ob-python.el initiate session error with py-shell
Date: Tue, 18 Feb 2020 21:23:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Jack,

Jack Kamm <address@hidden> writes:

> Unless it is standard to take the subject line as the
> commit message?

Yes, it is - although in stardiviner's patch, the subject line should
not have the asterisk.

You can check for the propre format of a patch by doing

~$ git format-patch HEAD~10

and read the 10 latest patches (hopefully they are well formatted.)

I often do tiny edits on patches to fix problems, don't hesitate to
do so when it does not affect the author's intent.

Thanks,

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]