emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo


From: Carsten Dominik
Subject: Re: Debugging at least 2 regressions in org-mode master breaking ox-hugo
Date: Mon, 11 May 2020 16:10:40 +0200

Hi everyone,

I just tried to archive something and hit again the issue that org-get-outline-paths undefined.  Is there a specific holdup why this function has not been moved back into org.el?

Thanks

Carsten


On Thu, Feb 27, 2020 at 3:02 PM Kaushal Modi <address@hidden> wrote:
Hello,

I recently updated to the latest org-mode master and it is failing ox-hugo[1] build and tests at 2 places.

Failure 1: org-get-outline-path has moved, and not mentioned in ORG-NEWS

Compiling ox-hugo.el now gives:

ox-hugo.el:4284:1: Warning: the function ‘org-get-outline-path’ is not known to be defined.

I see that defun has now moved to org-refile.el. I see that org-get-outline-path has nothing to do specific to refiling. Can that be moved back to org.el, or may be a separate library? Otherwise, ox-hugo.el will have to load org-refile.el too (yes, I don't use org-refile (yet), and that's how I discovered this :))

Failure 2: Change in parsing of org babel header arguments.

This was caught by my weekly Travis CI cron jobs for ox-hugo: https://travis-ci.org/kaushalmodi/ox-hugo/jobs/655410731#L2426

26c26
< {{< highlight emacs-lisp "hl_lines=1" >}}
---
> {{< highlight emacs-lisp "hl_lines=1 3-5" >}}

Earlier this kind of src block header:

#+begin_src emacs-lisp :hl_lines 1,3-5
...
#+end_src

got exported as 

{{< highlight emacs-lisp "hl_lines=1 3-5" >}}

The regression is that now it is getting exported as

{{< highlight emacs-lisp "hl_lines=1" >}}

The values that I have after the comma in ":hl_lines 1,3-5" are getting lost.

The relevant snippet where I parse the header arguments in ox-hugo.el is at https://github.com/kaushalmodi/ox-hugo/blob/f8ec4aa5ad7d92f94bd8dbb814d85f980be67aea/ox-hugo.el#L2563

This behavior change in org-babel-parse-header-arguments is also not documented in ORG-NEWS. I will now investigate what cause this regression.

...

--
Kaushal Modi


reply via email to

[Prev in Thread] Current Thread [Next in Thread]