emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: `#+author:' stopped setting the author to empty string


From: Nicolas Goaziou
Subject: Re: `#+author:' stopped setting the author to empty string
Date: Tue, 19 May 2020 10:04:51 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Kyle Meyer <address@hidden> writes:

> It bisects to b4e91b7e9 (New function: org-collect-keywords,
> 2020-04-26).  I haven't done much digging, but I was able to restore the
> behavior with the change below, which may be a bad idea for other
> reasons.
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 0e1e05239..a8db4c2bf 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files 
> alist)
>                         (push (cons key value) alist)
>                         (setq keywords (remove key keywords))
>                         (setq regexp (org-make-options-regexp keywords)))
> -                      ((not (org-string-nw-p value)) nil)
>                        ((null entry) (push (list key value) alist))
>                        (t (push value (cdr entry)))))))))))

At first glance, it looks harmless. If the test suite passes, we can
apply it.

Thank you.

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]