|
From: | Mario Frasca |
Subject: | Re: `with` as a list. |
Date: | Sat, 30 May 2020 16:29:27 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 |
so I rewrote the (dolist (col-with …) …) as (cl-loop for (col . with) in … do …).
so I could simplify `(car col-with)' and `(cdr col-with)', then I replaced the `do' with a `collect', so I could squash other `setq' into one, and finally removed the need to do a `reverse' on the result. less parentheses, and 4 lines less.
I added one regression test which is still respected, as is the rest of the test suite.
so maybe all is fine.putting order in the commits is now the challenge. thank you for your hints on git commit amend etc.
I hope to be back soon with a single commit... ciao, Mario
[Prev in Thread] | Current Thread | [Next in Thread] |