[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3] Re: [BUG] recently commits on master branch breaks command 'o
From: |
stardiviner |
Subject: |
[PATCH v3] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block' |
Date: |
Mon, 01 Jun 2020 15:32:07 +0800 |
User-agent: |
mu4e 1.4; emacs 28.0.50 |
Matthew Lundin <mdl@imapmail.org> writes:
> stardiviner <numbchild@gmail.com> writes:
>
>> Matthew Lundin <mdl@imapmail.org> writes:
>>
>>>
>>> I think you also need to replace the newline with a space in the upper
>>> case version.
>>>
>> Supposed there is \n after #+end_src. I also checked the original version
>> before
>> that change commit. The original has an newline. I write patch by comparing
>> before and after (side by side).
>
> I'm referring to this line in the patch:
>
> indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src
> ")
> ^
>
> The newline that needs to be removed is indicated by "^".
>
> You can see a correct similar version of this line on line 1932 of
> ob-core.el.
>
> The original line the problematic commit replaced would also have had a
> space in both, since it called either downcase or upcase on the string
> "#+begin_src ".
You're right, I updated the patch now. I really missed seeing that. :)
0001-PATCH-fix-5f0a9cca3-missing-space.patch
Description: Text Data
>
> Best,
>
> Matt
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
signature.asc
Description: PGP signature
- [PATCH v3] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block',
stardiviner <=