[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Update ob-haskell from deprecated inf-haskell-mode to haskel
Re: [PATCH] Update ob-haskell from deprecated inf-haskell-mode to haskell-interactive-mode
Sun, 26 Jul 2020 21:29:34 -0400
Seth Lee writes:
> Issue: compiling code in a source block that had an infinite list that
> would evaluate in the ghci. All code, even with `:compile` flag set
> would be run in ghci.
> Updating deprecated `inf-haskell-mode` to `haskell-interactive-mode`
> solves the issue for me.
> Source blocks flagged to compile will compile in a temp file, and
> those flagged otherwise will be run interactively. This is the
> intended behaviour.
> Patch attached.
Thanks for the patch.
> Subject: [PATCH] ob-haskell.el: Update deprecated functions
> * lisp/ob-haskell.el: Update to haskell-interactive-mode from inf-haskell-mode
> Deprecated commands from inf-haskell mode would send source blocks
> flagged to compile to the interpreter instead of compiling in a temp
I admit that I don't really have a good understanding of the situation
> lisp/ob-haskell.el | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/lisp/ob-haskell.el b/lisp/ob-haskell.el
> index 84e2d6c42..01d658615 100644
> --- a/lisp/ob-haskell.el
> +++ b/lisp/ob-haskell.el
> @@ -43,9 +43,9 @@
> (require 'comint)
> (declare-function haskell-mode "ext:haskell-mode" ())
> -(declare-function run-haskell "ext:inf-haskell" (&optional arg))
> +(declare-function run-haskell "ext:haskell-interactive-mode" (&optional arg))
> (declare-function inferior-haskell-load-file
> - "ext:inf-haskell" (&optional reload))
> + "ext:haskell-process-load-file" (&optional reload))
> (declare-function org-entry-get "org" (pom property &optional inherit
... I'm confused that the patch consists solely of modifying
declare-function calls. While that can appease the Emacs byte-compiler,
I'm not seeing how it could relate to the problem you describe.