[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lin

From: stardiviner
Subject: Re: [PATCH] Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Sat, 03 Oct 2020 15:34:27 +0800
User-agent: mu4e 1.5.5; emacs 28.0.50

Kyle Meyer <kyle@kyleam.com> writes:

> Ihor Radchenko writes:
>> Subject: [PATCH] Do not remove trailing newline when deleting planning info
>>  line.
>> * lisp/org.el (org-add-planning-info): Remove front newline instead of
>> trailing newline when deleting planning info is completetly removed
>> from a heading.  Fixes "Cycling through TODO workflow joins the next
>> line onto the current one".
> Did you intended to send a different patch?  This looks to be the same
> patch you sent at <https://orgmode.org/list/87ft78608z.fsf@localhost>.
> Also, can someone could provide an example case that was fixed by
> ee3c3b554 (org.el: Allow empty subtrees to be folded back, 2020-09-05)?
> The report that prompted that commit didn't include one:
> https://orgmode.org/list/CA+Yh0SRPgeMUYAD0ds3TZnwpPKq8_mpact-OeKK-rXoQNb-eEg@mail.gmail.com
> I tried with
> --8<---------------cut here---------------start------------->8---
> * TODO a
> * TODO b
> --8<---------------cut here---------------end--------------->8---
> If I understand the original message by Dmitrii (+cc), the request was
> that, since starting up folded shows the first heading as
>     * TODO a...
> tab should be able to fold the heading back to that state after
> expansion.  But, trying with the current master (16f505db2), tab still
> doesn't fold that heading on my end.  Unless we have a concrete reason
> to keep ee3c3b554, reverting it might be the best fix for this thread's
> issue.

Waited many days, seems no useful patch available. I suggest to revert that

[ stardiviner ]
       I try to make every word tell the meaning that I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

reply via email to

[Prev in Thread] Current Thread [Next in Thread]