[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: org-priority face has extra space at the end starting from vers
Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]
Sun, 11 Oct 2020 02:40:56 -0400
Protesilaos Stavrou writes:
> On 2020-09-29, 08:00 +0000, Roman Rudakov <email@example.com> wrote:
>> "Protesilaos Stavrou" <firstname.lastname@example.org> writes:
>>> Roman Rudakov <email@example.com> [2020-09-15, 18:50 +0000]:
>>>> I use theme which draw boxes around priority cookie. Before updating to
>>>> version 9.4 box was rendered just around square brackets, but since
>>>> version 9.4 it has additional space at the end.
>>>> I think it's related to the fact that org-priority face definition used
>>>> to use separate regex which didn't include space, and now it uses
>>>> variable org-priority-regexp which does include additional space
Thanks, all, for the excellent report and debugging.
>> I think proper value for `org-priority-regex` should be
>> ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of
>> the brackets, It won't break anything and face definition will be
> This is to confirm that I and Ilja (in Cc) get the desired behaviour by
> evaluating the suggested regexp.
I'm wary of changing the regexp. Although the docstring does suggest
the space shouldn't be a part of the first group, the group has included
the space since org-priority-regex was introduced way back in 2008. And
making the suggested change results in a failing test
(test-org/entry-put). So at this point, I'd lean towards adjusting the
I've applied a different fix for the regression (b1de0c8e4).