[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct

From: Kevin Foley
Subject: Re: [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct Type)
Date: Sun, 18 Oct 2020 21:50:52 -0400

Kyle Meyer <kyle@kyleam.com> writes:

> I imagine tastes vary on whether using cl-defstruct here is an overkill.
> (To my eyes, it is.)  More importantly, though, I think changing it now
> means we'd also need a compatibility layer, which doesn't seem worth the
> trouble.

I tried implementing it and realized:

1. It have issues with backwards compatibility (like you mentioned).
There are some workarounds but they add complexity 2. It can make other
things complicated. For example using `assoc' to look things up no longer
works so a lot needs to be updated.

Personally I think it's worth it as it makes things much clearer but I
understand why others may not feel that way and it's not something I
feel strongly enough about to push for.

> Thanks for noticing and for working on a patch.

My pleasure, I've attached a patch to this email.  I put something
together but I wasn't sure how it should be styled/formatted so if
anyone has any suggestions I'd be happy to update it.


Attachment: 0001-org-refile.el-org-refile-Add-description-of-RFLOC-to.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]