[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict

From: Jack Kamm
Subject: Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Date: Sat, 24 Oct 2020 07:06:26 -0700

Thanks Bastien, the Woof! tool looks interesting.

By the way, on seeing this thread again, I realized this patch probably should 
have been applied to the maint branch. So I've cherry picked it into there, and 
merged back into master.

Bastien <bzg@gnu.org> writes:

> Hi Jack and Adrian,
> Jack Kamm <jackkamm@gmail.com> writes:
>> Adrian Kummerländer <adrian.kummerlaender@student.kit.edu> writes:
>>> I noticed that after updating to Org 9.4 many of my Python-based Org
>>> files fail to execute with various `io.TextIOWrapper' related error
>>> messages. The reason for this is that opening the exec tmpfile as `f'
>>> shadows this possibly user-defined variable.
>>> The attached patch fixes this problem for me. As this is my first
>>> time contributing to Org I am especially open for any suggestions!
>> The patch looks good.  I've pushed it to master, after making a couple
>> minor fixes to the commit message (adding a TINYCHANGE cookie and
>> adjusting some of the spacing).
> Thanks for applying the patch, I'm marking it as "applied" through
> Woof! adding "X-Woof-Patch: applied" in the headers.
> Best,
> -- 
>  Bastien

reply via email to

[Prev in Thread] Current Thread [Next in Thread]