[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] Adaptive Org faces in headings?

From: Rob Davenport
Subject: RE: [PATCH] Adaptive Org faces in headings?
Date: Tue, 27 Oct 2020 18:30:50 +0000

Thank you very much for this patch, Ihor.   It fixes the issue on my system.   
I've only recently been getting org from the code.orgmode.org repo so Bastien 
kindly answered my first question as to why I wasn't seeing that patch yet. 
(The package I'm updating is coming from maint and not master.)   I see the fix 
in master but it is yet to be merged into maint so I don't expect to see it 
(just have to keep re-applying it).

I assume at some point commits in master will be merged into maint, correct?   
Is there a basic plan on when such merges might happen?  
Or am I doing something wrong?  I can wait - just curious about the process.  
(If it's documented somewhere I've missed, if someone can point me to it, I'll 
be quiet and go RTFM. 😊 )



Rob Davenport
Consulting R&D Engineer
ABB Cleveland
β€œDon’t look the other way. Make good architecture happen.”

-----Original Message-----
From: Emacs-orgmode <emacs-orgmode-bounces+rob.davenport=us.abb.com@gnu.org> On 
Behalf Of Protesilaos Stavrou
Sent: Friday, September 18, 2020 5:53
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Bastien <bzg@gnu.org>; Protesilaos Stavrou <info@protesilaos.com>; Org-mode 
<emacs-orgmode@gnu.org>; Diego Zamboni <diego@zzamboni.org>
Subject: Re: [PATCH] Adaptive Org faces in headings?

This email originated from outside of your organization. Please do not click on 
links or open attachments unless you recognize the sender and know the content 
is safe.

Ihor Radchenko <yantar92@gmail.com> [2020-09-17, 16:25 +0800]:

> The attached patch seems to fix the issue.
> Can anyone test?

I just tried this using the standard faces of 'emacs -Q' as well as custom 

In short, the patch fixes the issue on my side.  I tested whether faces on the 
headline would correctly inherit any of the following properties:

+ :height
+ :weight
+ :background
+ :overline

I also tested it with 'variable-pitch' headlines and, again, every construct 
that does not have a font family explicitly assigned to it will adapt to the 
underlying heading.  Excellent!

This is the kind of headline I tried:

     * TODO [#A] This is a test ~scaling-elements~ =faces-adapt= :good-stuff:

Also added links to confirm my findings.  Again, all good.

Protesilaos Stavrou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]