[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] change the ob-java default back to scripting mode

From: ian martins
Subject: Re: [PATCH] change the ob-java default back to scripting mode
Date: Thu, 29 Oct 2020 04:12:59 -0400

ok I will do that.

If I make the same change to dozens of tests in the same file, should I list them as separate bullets, or put the list of function names in parentheses, or is it better to omit the list if it would be long?

On Wed, Oct 28, 2020 at 9:36 PM Kyle Meyer <kyle@kyleam.com> wrote:
ian martins writes:

> Subject: [PATCH] ob-java.el: Change the default back to scripting mode
> * lisp/ob-java.el: Change the default to scripting mode.  Add name to
> authors.

The changelog entry should explicitly list the variables/functions that
are modified.  So in this case

    * lisp/ob-java.el (org-babel-default-header-args:java): ...

> A recent commit added functional mode and made it default, but this
> would break java source blocks for anyone that relied on the old
> default.  This sets the default back to scripting mode.

Thanks for restoring the behavior.

> I missed a name when I put the authors of ob-C and ob-python as the
> authors of ob-java.  Added it.

Please move this unrelated change to a separate commit.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]