[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enhance org-html--build-meta-info

From: TEC
Subject: Re: [PATCH] Enhance org-html--build-meta-info
Date: Wed, 16 Dec 2020 15:22:53 +0800
User-agent: mu4e 1.4.13; emacs 27.1

Jens Lechtenboerger <lechten@wi.uni-muenster.de> writes:

> I like this!


>> Maybe it should be applied to the rest (in ~org-html--build-meta-info~)?
>> I'm not sure.
> I’m not sure either.  Maybe people expect their typed characters,
> maybe not.  This might call for a new variable.

I'm tempted to leave the current behaviour as-is, and then we can
introduce a new variable if we want later :)

> I like the new variant much better.  However, I still do not
> understand why you pass the title into org-html-meta-tags-default
> just to ignore it.  The title is already dealt with elsewhere, isn’t
> it?

For people who want to customise this to add metadata, the page title is
something they're probably interested in. If so, I think it's work
giving the title processed by org-html--build-meta-info as it's not so
simple as (plist-get info :title). Worst case, the argument just sits
there and is ignored :P

> Some comments raise complaints by checkdoc (lines too long, no
> sentence in fist line).  (Actually, the file has more problems in
> that regard.)

Ooops, I thought I took care of that. Looks like I'll be taking another

Would be nice my issues weren't one of dozens throughout the file, it
makes it a bit harder to notice errors coming from /my/ section.

> Many thanks for your continued work!

Thanks for your testing and feedback!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]