[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] org-mac-link: Disable Evernote capture by default
From: |
Aaron Jensen |
Subject: |
[PATCH] org-mac-link: Disable Evernote capture by default |
Date: |
Wed, 17 Feb 2021 09:53:32 -0600 |
The two `shell-command-to-string` invocations during eval are
extremely slow. Users of Evernote should `org-mac-grab-Evernote-app-p`
and `org-mac-evernote-path` explicitly.
* contrib/lisp/org-mac-link.el (org-mac-grab-Evernote-app-p): Default
to nil
(org-mac-evernote-path): Default to nil and add a function of the same
name that will either use the variable or a shell invocation to mdfind
(org-mac-evernote-note-open): Use the function version of org-mac-evernote-path
(org-as-get-selected-evernote-notes): Use the function version of
org-mac-evernote-path
---
contrib/lisp/org-mac-link.el | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/contrib/lisp/org-mac-link.el b/contrib/lisp/org-mac-link.el
index e56354c4f..ec004d8b9 100644
--- a/contrib/lisp/org-mac-link.el
+++ b/contrib/lisp/org-mac-link.el
@@ -207,18 +207,13 @@
:group 'org-mac-flagged-mail
:type 'string)
-(defcustom org-mac-grab-Evernote-app-p
- (< 0 (length (shell-command-to-string
- "mdfind kMDItemCFBundleIdentifier ==
'com.evernote.Evernote'")))
+(defcustom org-mac-grab-Evernote-app-p nil
"Add menu option [e]vernote to grab note links from Evernote.app."
:tag "Grab Evernote.app note links"
:group 'org-mac-link
:type 'boolean)
-(defcustom org-mac-evernote-path (replace-regexp-in-string (rx (* (any "
\t\n")) eos)
- ""
-
(shell-command-to-string
- "mdfind
kMDItemCFBundleIdentifier == 'com.evernote.Evernote'"))
+(defcustom org-mac-evernote-path nil
"The path to the installed copy of Evernote.app. Do not escape spaces as the
AppleScript call will quote this string."
:tag "Path to Evernote"
:group 'org-mac-link
@@ -809,11 +804,21 @@ after heading."
(org-link-set-parameters "mac-evernote" :follow #'org-mac-evernote-note-open)
+(defun org-mac-evernote-path ()
+ "Get path to evernote.
+First consider the value of ORG-MAC-EVERNOTE-PATH, then attempt to find it.
+Finding the path can be slow."
+ (or org-mac-evernote-path
+ (replace-regexp-in-string (rx (* (any " \t\n")) eos)
+ ""
+ (shell-command-to-string
+ "mdfind kMDItemCFBundleIdentifier ==
'com.evernote.Evernote'"))))
+
(defun org-mac-evernote-note-open (noteid _)
"Open a note in Evernote"
(do-applescript
(concat
- "tell application \"" org-mac-evernote-path "\"\n"
+ "tell application \"" (org-mac-evernote-path) "\"\n"
" set theNotes to get every note of every notebook where its local id
is \"" (substring-no-properties noteid) "\"\n"
" repeat with _note in theNotes\n"
" if length of _note is not 0 then\n"
@@ -828,7 +833,7 @@ after heading."
"AppleScript to create links to selected notes in Evernote.app."
(do-applescript
(concat
- "tell application \"" org-mac-evernote-path "\"\n"
+ "tell application \"" (org-mac-evernote-path) "\"\n"
" set noteCount to count selection\n"
" if (noteCount < 1) then\n"
" return\n"
--
2.28.0
- [PATCH] org-mac-link: Disable Evernote capture by default,
Aaron Jensen <=