[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ob-tangle.el: Speed up tangling
From: |
Bastien |
Subject: |
Re: [PATCH] ob-tangle.el: Speed up tangling |
Date: |
Sat, 01 May 2021 22:32:41 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Sébastien,
Sébastien Miquel <sebastien.miquel@posteo.eu> writes:
> Indeed, I hadn't thought to run the tests, sorry. I've fixed my code
> and modified the `block-order` test in order for it to pass.
Applied with commit a2cb9b853, thank you very much for the updated patch.
> The patch does modify the order of the tangled blocks. When several
> blocks with different languages are tangled to the same file, they
> used to be grouped according to language, and are now tangled in the
> order in which they appear. I assumed this was an oversight in the
> previous code, but since this test exists, maybe it was intended ?
>
> Nicolas Goaziou wrote this test, perhaps he could comment on this.
Sure, feel free to adapt the code further if needed after discussing
this.
Thanks,
--
Bastien