[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Possibility of using alternative separators in macros
From: |
Juan Manuel Macías |
Subject: |
Re: [PATCH] Possibility of using alternative separators in macros |
Date: |
Sat, 15 May 2021 20:14:09 +0000 |
Hi Bastien,
Bastien writes:
> I'll let Eric test and comment, but in the meantime, I'm just
> noticing the patch breaks many tests in master.
>
> If Nicolas thinks this change is good and Eric validate the patch,
> please prepare one with a commit message, updating the tests too.
Ok, if necessary I will prepare an updated version of the patch, with
the updated tests, and with a commit message (a thousand apologies for
my continuous forgetting in commit messages...).
I have noticed certain bugs in my patch, especially within
org-element-macro-parser (a bad regexp and something else). That caused
macros with a single argument to be incorrectly interpreted (and it also
caused an error in one of the tests). If Eric (or someone else) wants
an updated version of the patch I could send it him.
Anyway, I admit that I have become somewhat skeptical about the
usefulness of my patch. Perhaps, as a patch, it is too premature and
perhaps it's better to leave the macros issue, for the moment, as it
is... What do you think?
Best regards,
Juan Manuel
- Re: [PATCH] Possibility of using alternative separators in macros, (continued)
- Re: [PATCH] Possibility of using alternative separators in macros, Christian Moe, 2021/05/02
- Re: [PATCH] Possibility of using alternative separators in macros, Maxim Nikulin, 2021/05/12
- Re: [PATCH] Possibility of using alternative separators in macros, Christian Moe, 2021/05/16
- Re: [PATCH] Possibility of using alternative separators in macros, Maxim Nikulin, 2021/05/17
- Re: [PATCH] Possibility of using alternative separators in macros, Christian Moe, 2021/05/17
Re: [PATCH] Possibility of using alternative separators in macros, Eric S Fraga, 2021/05/02
Re: [PATCH] Possibility of using alternative separators in macros, Eric S Fraga, 2021/05/11
- Re: [PATCH] Possibility of using alternative separators in macros, Juan Manuel Macías, 2021/05/11
- Message not available
- Re: [PATCH] Possibility of using alternative separators in macros, Juan Manuel Macías, 2021/05/11
- Re: [PATCH] Possibility of using alternative separators in macros, Bastien, 2021/05/15
- Re: [PATCH] Possibility of using alternative separators in macros,
Juan Manuel Macías <=
- Re: [PATCH] Possibility of using alternative separators in macros, Bastien, 2021/05/15
- Re: [PATCH] Possibility of using alternative separators in macros, Juan Manuel Macías, 2021/05/15
- Re: [PATCH] Possibility of using alternative separators in macros, Bastien, 2021/05/16
- Re: [PATCH] Possibility of using alternative separators in macros, Maxim Nikulin, 2021/05/16