Re: [PATCH] Do not throw error when parameter of :tangle is not a string

[Jacopo De Simoi]

Hi Sébastien,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, July 8th, 2021 at 4:44 AM, Sébastien Miquel 
<sebastien.miquel@posteo.eu> wrote:

> Hi,
>
> Jacopo De Simoi writes:
>
> > in the current master branch, if the parameter :tangle of a src block is not
> >
> > a string, tangling fails by throwing an error when calling `file-name- 
> > directory' This patch checks if the parameter is a string before calling` 
> > file-name-directory'.
> >
> > This makes construct such as :tangle (when condition-applies "filename") 
> > work
> >
> > again (as they did a few versions ago…)
>
> Thanks for the patch. It looks good to me (had to run `dos2unix' to apply).

Dos2unix? I'll make sure it doesn't happen again. It might have to do with 
having sent the patch from Android.

>To clarify, it fixes` :tangle (when condition-applies "filename")' when the
>
> condition doesn't apply, such as `(when nil "filename")'.

Yes, I will update the commit message and resubmit. Thanks!
>
> Regards,
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Sébastien Miquel