[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: org-attach-sync uses directory-empty-p (new in Emacs 28)

From: Maxim Nikulin
Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28)
Date: Wed, 11 Aug 2021 23:16:06 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 11/08/2021 03:52, Marco Wahl wrote:
Kyle Meyer <kyle@kyleam.com> writes:

In 61e083732 (org-attach: Possibly delete empty attach directory,
2021-07-09), you added a call to directory-empty-p.  This function was
introduced in Emacs's 0806075520 (Add directory-empty-p and new argument
COUNT for directory-files-*, 2020-11-02) and hasn't yet made it into a

Could you update org-attach-sync to avoid using directory-empty-p (e.g.,
by inlining it or by adding a compatibility alias)?

Starting from Arthur's suggestion and Kyle's hint to the compatibility
alias I put org-directory-empty-p into org-compat.el.  So there is
org-directory-empty-p now which provides the functionality of
directory-empty-p from Emacs 28 for smaller version Emacsen.

Unfortunately current code causes a compiler warning at least when Emacs-25.2 is used:

Compiling single /home/ubuntu/org-mode/lisp/org-compat.el...

In end of data:
org-compat.el:1255:1:Warning: the function ‘directory-empty-p’ is not known to
    be defined.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]