[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: org-src-font-lock-fontify-block should be wrapped with save-mat
Re: Bug: org-src-font-lock-fontify-block should be wrapped with save-match-data [9.3.7 (9.3.7-4-gba6ca7-elpaplus @ mixed installation! /mnt/c/Users/toz/Weiterbildung/Soft/Emacs/ and /mnt/c/Users/toz/.emacs.d/elpa/org-plus-contrib-20200615/)
Tue, 24 Aug 2021 23:57:53 +0700
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0
On 23/08/2021 14:45, Timothy wrote:
Thanks for your efforts. I have prepared a patch accordingly that wraps
org-src-font-lock-fontify-block’s body with save-match-data (attached).
If I don’t hear anything bad about it in the next few days, I’ll push it :)
Please let me know if my commit message agrees with your understanding of the
Timothy, are you able to reproduce the issue with performance? Due to
"Large source block causes org-mode to be unusable" I assume that it
could be quite severe. On the other hand I tried to insert an .el file
into org-guide.org and I have not noticed slow down. Actually my
curiosity is caused by other performance issues, so I am interested if
the effect may be broader.
The following question may be dumb since I am not familiar how font lock
works in Emacs. Is it necessary to wrap whole function? I do not see
explicit operation with regexps. The only suspecting line is
I am not sure whether the body of `org-src-font-lock-fontify-block'
should be wrapped or its call site.
Feel free to disregard my questions since fontification is far aside
from my experience.