[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil

From: Morgan Willcock
Subject: Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil
Date: Tue, 31 Aug 2021 13:42:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)

Timothy <tecosaur@gmail.com> writes:

> Hi Morgan,
>> I’ve attached a patch to fix an issue where tab characters are generated by
>> the ASCII exporter when `indent-tabs-mode’ has its default value of t.
> Thanks for finding this bug, fixing it, and sending us it 🙂. I was able to
> reproduce your test case with “emacs -Q” (thanks for that, by the way).
> As you suspected, with the small number of changed lines, this would be fine 
> to
> accept without FSF assignment.

Great! Thank you for taking a look.

> However, your “patch” seems to consist of a diff at the bottom of your email 
> and
> a commit message at the top?? It would be preferable if you could provide a
> “proper” patch, that way you can get attribution for your help instead of just
> someone committing it on your behalf.

I used `git send-email` which is listed as being OK on the website:

  "If you have configured git to use send-email, then you can use that."
                                 -- https://orgmode.org/contribute.html

The mail can be applied with `git am` and the commit message will be
correct. I'm also happy to resend as a separate patch if that is the


reply via email to

[Prev in Thread] Current Thread [Next in Thread]