|Subject:||Re: New source block results option for attaching file to node|
|Date:||Tue, 31 Aug 2021 12:43:22 -0700|
Thanks for submitting your first patch to Org! 🎉
Regarding the purpose of the patch, I take it this is useful with source blocks that return a file patch and should be added as an attachment? Would you mind expanding on this use case? Oh, and
org-attach-dirdoesn’t show up a function or variable for me, I take it you meant something else?
Lastly, with your commit message, you’ve clearly looked at the requested commit message format 😊. There’s the odd typo (“theh”) and the line length is too long. It’s good if you hard line-wrap to 72 characters (if you use Magit, this should happen automatically FYI). Other than that it looks good to me.
All the best,
TimothyAn additional option for use with ":results file" that moves the returned path to the node attachment directory (as returned by org-attach-dir), creating it if necessary.First time submitting a patch. Any feedback is appreciated.-ryan
|[Prev in Thread]||Current Thread||[Next in Thread]|