[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] org-encode-time compatibility and convenience helper

From: Max Nikulin
Subject: Re: [PATCH v4] org-encode-time compatibility and convenience helper
Date: Thu, 5 May 2022 22:22:21 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 04/05/2022 16:56, Ihor Radchenko wrote:
Max Nikulin writes:

1 unexpected results:
    FAILED  test-org-clock/clocktable/ranges

Resetting timezone to UTC should be fixed in timestamps generated by a testing helper function. I was disappointed that `mapcar' can not be used with multiple lists, but I have found an old function created namely for zeroing nils in timestamps.

Since it is expected to fail in some Emacs versions, you can just wrap
the call into with-no-warnings:

(ignore-errors (with-no-warnings (encode-time '(0 0 0 1 1 1971))))

Thank you, I have added this trick.

I have created one more patch with tests quite close to the case caused this series.

It seems, no tests fail even in Australia/Eucla timezone famous for its 45 min offset.

Attachment: 0001-Use-unknown-DST-instead-of-standard-time-in-timestam.patch
Description: Text Data

Attachment: 0002-Fix-tests-for-org-parse-time-string-and-org-clock.patch
Description: Text Data

Attachment: 0003-Use-higher-level-helpers-instead-of-encode-time.patch
Description: Text Data

Attachment: 0004-testing-lisp-Use-org-time-string-to-time.patch
Description: Text Data

Attachment: 0005-org-macs.el-Introduce-a-helper-for-encode-time.patch
Description: Text Data

Attachment: 0006-Use-org-encode-time-helper-macro.patch
Description: Text Data

Attachment: 0007-test-org.el-Add-some-tests-for-org-test-with-timezon.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]