[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-macs.el: Do not compare wall time and file modification

From: Max Nikulin
Subject: Re: [PATCH] org-macs.el: Do not compare wall time and file modification time
Date: Wed, 11 May 2022 19:28:13 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1

On 06/05/2022 23:56, Max Nikulin wrote:
Mark Barton to emacs-orgmode, emacs-devel. master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc. Tue, 26 Apr 2022 23:37:50 -0700. https://list.orgmode.org/BF5B9308-3FEF-4DC6-98C9-BFF36F19D36C@gmail.com

The change also breaks org-file-newer-than-p function that triggered the
debugger while loading my init that uses org babel.

I think, it should be fixed in the bugfix Org branch.  The attached patch is a compromise to some degree, but I do not see a robust solution.

Thinking more I realized that `org-file-newer-than-p' should not be reused for `org-babel-load-file'. I am attaching an updated patch for which I do not see any real drawback.

The only change in behavior is that if a file had modification time in future and it is overwritten by `org-compile-time' to current time than the function reports failure. I consider such case as a rare and peculiar one.

Attachment: 0001-org-macs.el-Do-not-compare-wall-time-and-file-modifi.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]