[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full

From: Ihor Radchenko
Subject: Re: [BUG] org-auto-repeat-maybe: error "Can’t expand minibuffer to full frame" and missing log note
Date: Mon, 04 Jul 2022 20:03:29 +0800

Bhavin Gandhi <bhavin7392@gmail.com> writes:

> While looking at the *Messages* buffer, I came across the command
> y-or-n-p-insert-y. There are commands for n, and other keys. When we
> press y, M-p etc, these commands get executed. So, even if we manage to
> fix the initial example in Emacs, the hook will still run while one is
> in the minibuffer.

This explains the observed behavior.

A possible fix could be let-binding post-command-hook to
(delq #'org-add-log-note post-command-hook), though we may get a similar
issue in other context in future.

A better fix may relate to the fact that org-add-log-setup is usually
used to run org-add-log-note at the end of current command. y-or-n-p or
any other kind of command (e.g. added via advice) will break this
assumption we use. So, org-add-log-setup could also store
`this-command', say, in `org-log-note-this-command' and
`org-add-log-note' can then execute only when `this-command' is the same
with `org-log-note-this-command'. WDYT?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]