[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] org-test: Run all ol tests on make test

From: Max Nikulin
Subject: [PATCH v2] org-test: Run all ol tests on make test
Date: Thu, 28 Jul 2022 22:14:29 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 28/07/2022 21:31, Ihor Radchenko wrote:
Max Nikulin writes:

On 27/07/2022 10:49, Ihor Radchenko wrote:

You missed the

         (if org-test-selector org-test-selector "\\(org\\|ob\\)"))

I have notices that cases in test-oc.el are named test-org-cite/... So I
am considering renaming tests in test-ol.el in the same way from
test-ol/... to test-org-link/... instead of modifying selectors. I have
not noticed with approach to naming is recommended.

Either way is fine. Ideally, we should stick to org- prefix, as expected
from Elisp conventions. But we are already kind of breaking this
convention by having all the oc- ol-, etc files.

I have decided that I prefer to have org-test common prefix even though it causes discrepancy test-ol.el file vs. test-org-link/... cases.

Attachment: 0001-test-ol-Rename-cases-to-match-the-default-selector.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]