Re: [PATCH v8] ol.el: add description format parameter to org-link-parameters

[Max Nikulin]

On 25/07/2022 18:55, Hugo Heagren wrote:
> > In any case, we cannot, unfortunately, use map-do here and should
> > probably fall back to the previous version with cl-loop.
>
> You're right, this is strange. Oh well, I've moved back to the version
> of the macro which used `cl-loop' in the current patch. Nothing else
> is changed. All the tests pass for me.

Hugo, almost certainly you are tired by so many iterations, but I still 
can not approve your patch. It is again Emacs-26 and likely the last 
`should' form with (org-link-parameters nil). I hope, you have not lost 
motivation yet and you will fix this test failure.

Test test-ol/insert-link-insert-description backtrace:
  signal(error ("rx form ‘or’ requires at least 1 args"))
  apply(signal (error ("rx form ‘or’ requires at least 1 args")))
  (setq value-7590 (apply fn-7588 args-7589))
  (unwind-protect (setq value-7590 (apply fn-7588 args-7589)) (setq fo
  (if (unwind-protect (setq value-7590 (apply fn-7588 args-7589)) (set
  (let (form-description-7592) (if (unwind-protect (setq value-7590 (a
  (let ((value-7590 (quote ert-form-evaluation-aborted-7591))) (let (f
  (let* ((fn-7588 (function null)) (args-7589 (condition-case err (let
  (closure (t) nil (let* ((fn-7563 (function string=)) (args-7564 (con
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name test-ol/insert-link-insert-descriptio
  ert-run-or-rerun-test(#s(ert--stats :selector "test-ol/" :tests [#s(
  ert-run-tests("test-ol/" #f(compiled-function (event-type &rest even
  ert-run-tests-batch("test-ol/")
  ert-run-tests-batch-and-exit("test-ol/")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("test-ol/")
  eval((org-test-run-batch-tests org-test-select-re))
  command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
  command-line()
  normal-top-level()
Test test-ol/insert-link-insert-description condition:
    (error "rx form ‘or’ requires at least 1 args")
   FAILED   5/13  test-ol/insert-link-insert-description