[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree'
From: |
Max Nikulin |
Subject: |
Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree' |
Date: |
Sat, 17 Sep 2022 18:07:54 +0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 |
On 29/11/2021 19:02, Max Nikulin wrote:
=C-c C-x C-y= ~org-paste-subtree~ fails just after Emacs start.
Maybe there are more similar issues.
- Start *new* instance of emacs.
printf '%b' '* Heading\n\nbody\n' |
xclip -in -selection clipborad >/dev/null
- Try =C-c C-x C-y= or [[elisp:(org-paste-subtree)]]
+ Actual result is the following message:
: user-error: The kill is not a (set of) tree(s). Use ‘C-y’ to
yank anyway
This is a reminder about the pending patch. The bug is still present in
the main branch.
diff --git a/lisp/org.el b/lisp/org.el
index 025513e7a..55953e97b 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -7774,7 +7774,7 @@ the inserted text when done.
When REMOVE is non-nil, remove the subtree from the clipboard."
(interactive "P")
- (setq tree (or tree (and kill-ring (current-kill 0))))
"and kill-ring" was added in the commit
63f95c5c4 Carsten Dominik, "Release 4.34" 2008-01-31 11:31:55 +0100
and might be related to
Philip Rooke. remember problem in 4.33? Wed, 24 May 2006 08:49:28 +0000
https://list.orgmode.org/loom.20060524T103500-160@post.gmane.org/T/#u
but I may trigger
let*: Wrong type argument: char-or-string-p, nil
on the main branch using `org-capture' with the "* A\nkill: %c" template
and empty kill ring and X primary selection and clipboard. Either I can
not figure out what was the actual problem or protection was added in
unrelated code.
So I still believe that my patch fixes the issue, but there may be more
bugs around.
- Re: [PATCH] [BUG] org.el: Fix first call of `org-paste-subtree',
Max Nikulin <=