emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-datetree.el: Allow datetrees with TODO, priority, tags


From: Ihor Radchenko
Subject: Re: [PATCH] org-datetree.el: Allow datetrees with TODO, priority, tags
Date: Sat, 07 Jan 2023 12:54:53 +0000

Ilya Chernyshov <ichernyshovvv@gmail.com> writes:

>  (defun org-datetree--find-create
> @@ -169,18 +167,19 @@ component.  If INSERT is non-nil and there is no match 
> then it is
>  inserted into the buffer."
>    (when (or month day)
>      (org-narrow-to-subtree))
> -  (let ((re (format regex-template year month day))
> +  (let ((re (format org-complex-heading-regexp-format
> +                    (format regex-template year month day)))

These changes make the docstring for `org-datetree--find-create'
incorrect:

    (defun org-datetree--find-create
        (regex-template year &optional month day insert)
      "Find the datetree matched by REGEX-TEMPLATE for YEAR, MONTH, or DAY.
    REGEX-TEMPLATE is passed to `format' with YEAR, MONTH, and DAY as
    arguments.  Match group 1 is compared against the specified date
    component.  If INSERT is non-nil and there is no match then it is
    inserted into the buffer."

Please update the docstring to reflect the new behaviour.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]