|
From: | Max Nikulin |
Subject: | Re: [PATCH v5] org.el: Warning for unsupported markers in `org-set-emphasis-alist' |
Date: | Mon, 6 Feb 2023 22:11:48 +0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
On 02/02/2023 17:53, Ihor Radchenko wrote:
I further improved the patch adding variable watcher. This should catch everything. See the attached.
`add-variable-watcher' may be fragile for lists, but it should catch most obvious attempts to modify the list. To my surprise `add-variable-watcher' is used in just a few places in Emacs sources.
From: Max Nikulin<manikulin@gmail.com>
Taking into account your modifications, I think you can reset the commit author.
+(defun org-emphasis-alist--check-value (symbol value &optional operation _) + "Verify the VALUE of `org-emphasis-alist' SYMBOL. +Issue a warning when the value is not supported. +Optional argument OPERATION is intended for `add-variable-watcher' +usage, which see." + (when (memq operation '(set let))
I am unsure concerning let. Perhaps the user needs something strange if let is used in some code instead of usual setq in init.el, so behavior may be too noisy.
+ (option (const :tag "Deprecated ignored constant" verbatim)))))
Looking into easy customization UI I have found current tag text rather confusing. What about "Verbatim (deprecated and ignored)"?
Thank you for further improvements of the patch. I will not object if you apply the patch as is.
Are you still going to fix the manual a bit?Ihor Radchenko to emacs-orgmode… Re: c47b535bb origin/main org-element: Remove dependency on ‘org-emphasis-regexp-components’ Thu, 18 Nov 2021 20:25:33 +0800. https://list.orgmode.org/87tug93b2a.fsf@localhost
[Prev in Thread] | Current Thread | [Next in Thread] |