[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix some emacs-30 byte-compile warnings
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Fix some emacs-30 byte-compile warnings |
Date: |
Fri, 17 Feb 2023 14:08:04 +0000 |
Robert Pluim <rpluim@gmail.com> writes:
> Ihor> 3 unexpected results:
> Ihor> FAILED test-org-table/copy-field
> Ihor> FAILED test-org-table/references/mode-string-N
> Ihor> FAILED test-org-table/references/mode-string-none
>
> Hmm, at least the first one is because the code in the 't' branch of
> (if (and (eq elements "") (not keep-empty))
>
> in org-table-make-reference now runs, and it results in
>
> (eval '(identity))'
>
> Of course fixing that causes other problems <sigh>
Meanwhile, I fixed all the other warnings.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
Now, only this org-table problem remains.
It is clearly a bug of some kind - the code is not doing what it
intended originally. But we need to understand org-table.el better to
fix this...
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- Re: [PATCH] Fix some emacs-30 byte-compile warnings,
Ihor Radchenko <=