[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Justify/align image previews in org-mode
From: |
Karthik Chikmagalur |
Subject: |
Re: [PATCH] Justify/align image previews in org-mode |
Date: |
Mon, 18 Dec 2023 01:19:49 -0800 |
Please ignore the previous patch and use this one instead. I've fixed a
bug and a couple of formatting errors.
Karthik
diff --git a/lisp/org.el b/lisp/org.el
index 30a4e7aef..ad2ad2332 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15673,6 +15673,25 @@ cache Display remote images, and open them in
separate buffers
(const :tag "Display and silently update remote images" cache))
:safe #'symbolp)
+(defcustom org-image-align nil
+ "How to align images previewed using `org-display-inline-images'.
+
+Only stand-alone image links are affected by this setting. These
+are links without surrounding text.
+
+Possible values of this option are:
+
+nil Insert image at specified position (same as left-alignment).
+center Center image previews.
+right Right-align image previews."
+ :group 'org-appearance
+ :package-version '(Org . "9.7")
+ :type '(choice
+ (const :tag "Don\\='t align image previews" nil)
+ (const :tag "Center image previews" center)
+ (const :tag "Right align image previews" right))
+ :safe #'symbolp)
+
(defun org--create-inline-image (file width)
"Create image located at FILE, or return nil.
WIDTH is the width of the image. The image may not be created
@@ -15807,7 +15826,8 @@ buffer boundaries with possible narrowing."
(when file (setq file (substitute-in-file-name file)))
(when (and file (file-exists-p file))
(let ((width (org-display-inline-image--width link))
- (old (get-char-property-and-overlay
+ (align (org-image--align link))
+ (old (get-char-property-and-overlay
(org-element-begin link)
'org-image-overlay)))
(if (and (car-safe old) refresh)
@@ -15833,6 +15853,16 @@ buffer boundaries with possible narrowing."
(list 'org-display-inline-remove-overlay))
(when (boundp 'image-map)
(overlay-put ov 'keymap image-map))
+ (when align
+ (overlay-put
+ ov 'before-string
+ (propertize
+ " " 'face 'default
+ 'display
+ (pcase align
+ ((or 'center 'justify)
+ `(space :align-to (- center (0.5 .
,image))))
+ ('right `(space :align-to (- right
,image)))))))
(push ov org-inline-image-overlays))))))))))))))))
(defvar visual-fill-column-width) ; Silence compiler warning
@@ -15894,6 +15924,37 @@ buffer boundaries with possible narrowing."
org-image-actual-width)
(t nil))))
+(defun org-image--align (link)
+ "Determine the alignment of the image link.
+
+This is controlled globally by the option `org-image-align', and
+per image by the value of `:align' in the affiliated keyword
+`#+attr_org'.
+
+The result is one of the symbols center, justify or right. The
+first two will cause the image preview to be centered, the last
+will cause it to be right-aligned. A return value of nil implies
+no special alignment -- the image preview is overlaid on the link
+exactly where it appears in the buffer."
+ (let ((par (org-element-lineage link 'paragraph)))
+ ;; Only apply when image is not surrounded by paragraph text:
+ (when (and (= (org-element-property :begin link)
+ (org-element-property :contents-begin par))
+ (<= (- (org-element-property :contents-end par)
+ (org-element-property :end link))
+ 1)) ;account for trailing newline
+ (save-match-data
+ ;; Look for a valid :align keyword (left, center, justify or right)
+ (if-let* ((attr-org (car-safe (org-element-property :attr_org par)))
+ ((string-match ":align[[:space:]]+\\(\\w+\\)" attr-org))
+ (attr-align (car-safe
+ (memq (intern (match-string 1 attr-org))
+ '(left center justify right)))))
+ (unless (eq attr-align 'left) attr-align)
+ ;; No image-specific keyword, check global alignment property
+ (when (memq org-image-align '(center justify right))
+ org-image-align))))))
+
(defun org-display-inline-remove-overlay (ov after _beg _end &optional _len)
"Remove inline-display overlay if a corresponding region is modified."
(when (and ov after)
- [PATCH] Justify/align image previews in org-mode, Karthik Chikmagalur, 2023/12/17
- Re: [PATCH] Justify/align image previews in org-mode,
Karthik Chikmagalur <=
- Re: [PATCH] Justify/align image previews in org-mode, Ihor Radchenko, 2023/12/18
- Re: [PATCH] Justify/align image previews in org-mode, Karthik Chikmagalur, 2023/12/18
- Re: [PATCH] Justify/align image previews in org-mode, Ihor Radchenko, 2023/12/18
- Re: [PATCH] Justify/align image previews in org-mode, Karthik Chikmagalur, 2023/12/18
- Re: [PATCH] Justify/align image previews in org-mode, Karthik Chikmagalur, 2023/12/18
- Re: [PATCH] Justify/align image previews in org-mode, Ihor Radchenko, 2023/12/19
- Re: [PATCH] Justify/align image previews in org-mode, Karthik Chikmagalur, 2023/12/19
- Re: [PATCH] Justify/align image previews in org-mode, Ihor Radchenko, 2023/12/21
- Re: [PATCH] Justify/align image previews in org-mode, Ihor Radchenko, 2023/12/19
- Re: [PATCH] Justify/align image previews in org-mode, Bastien Guerry, 2023/12/25