[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6
From: |
Al Haji-Ali |
Subject: |
Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)] |
Date: |
Thu, 20 Jun 2024 09:00:12 +0100 |
On 19/06/2024, Ihor Radchenko wrote:
> Al Haji-Ali <abdo.haji.ali@gmail.com> writes:
>
>> On 18/06/2024, Ihor Radchenko wrote:
>>> Hmm. Thanks, but the patch does not apply on my side.
>>> May you instead create a patch as a separate file, add the commit
>>> message, and attach that patch file in the email reply?
>>
>> See attached.
>
> Thanks. Although this is a different kind of patch. And it is doing too
> much - we do not want to expand all the names via `file-truename'
> because you may have a situation like
>
> /path/to/file1.org
> /path/to/symlinks/name-is-completely-different.org
>
> Then, using `file-truename' may be confusing for people who expect the
> symlink name to be displayed.
I am not sure what would be the correct approach. Perhaps the true-name
expansion should be conditioned on the value of `find-file-visit-truename`.
> I am thus attaching an alternative patch.
> May you please test if it fixes the problem on your side?
I think it's missing calling `file-truename` call on `filename`, see attached
patch.
Best regards,
-- Al
org-refile-targets.patch
Description: Text Data
- [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Al Haji-Ali, 2024/06/17
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Ihor Radchenko, 2024/06/17
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Al Haji-Ali, 2024/06/17
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Ihor Radchenko, 2024/06/18
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Al Haji-Ali, 2024/06/18
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Ihor Radchenko, 2024/06/19
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)],
Al Haji-Ali <=
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Ihor Radchenko, 2024/06/20
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Al Haji-Ali, 2024/06/20
- Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)], Ihor Radchenko, 2024/06/20