Re: [PATCH] Add repeat-map for navigation commands

[Visuwesh]

[திங்கள் செப்டம்பர் 09, 2024] Ihor Radchenko wrote:

>> ... I've attached a patch which
>> adds a repeat-map to org-keys.el but this pointed out that org-mode
>> lacks a org-up-heading command so I've resorted to using
>> outline-up-heading.
>
> It is not the only one. But outline version should also work.

I just realised that we would need a few defalias-es if we are going to
have outline commands in the repeat-map to avoid overriding
outline-navigation-repeat-map when one uses outline-up-heading in
outline-minor-mode or outline-mode.

[திங்கள் செப்டம்பர் 09, 2024] Karthik Chikmagalur wrote:

>>> From 8b980efcd9497e395f4d82a1304267ae4426b00d Mon Sep 17 00:00:00 2001
>>> From: Visuwesh <visuweshm@gmail.com>
>>> Date: Mon, 9 Sep 2024 19:46:47 +0530
>>> Subject: [PATCH] Add repeat-mode keymap for navigation commands
>>>
>>> * org-keys.el (org-navigation-repeat-map): Add repeat-map to make
>>> navigation easier when repeat-mode is turned on.
>>
>> May you also add a news entry?
>> Ideally, we should also document this in the manual.

I will add this along with the above in the next patch.

> Do you think it makes sense to add repeat-maps for other next/previous
> commands in Org, such as org-next-link and org-previous-link?  I've been
> using this for a while (they don't use defvar-keymap as I wrote them a
> while ago):
>
> (defvar org-link-navigation-repeat-map
>   (let ((map (make-sparse-keymap)))
>     (define-key map (kbd "n") #'org-next-link)
>     (define-key map (kbd "p") #'org-previous-link)
>     (define-key map (kbd "v") #'org-link-preview) ;toggle preview for link at 
> point
>     map))
>
> (map-keymap
>  (lambda (_ cmd)
>    (put cmd 'repeat-map 'org-link-navigation-repeat-map))
>  org-link-navigation-repeat-map)
>
> (defvar org-block-navigation-repeat-map
>   (let ((map (make-sparse-keymap)))
>     (define-key map (kbd "f") #'org-next-block)
>     (define-key map (kbd "b") #'org-previous-block)
>     map))
>
> (put 'org-next-block     'repeat-map 'org-block-navigation-repeat-map)
> (put 'org-previous-block 'repeat-map 'org-block-navigation-repeat-map)

I also have a repeat-map for org-todo since I have
org-support-shift-select to t which makes changing the TODO when in the
body text quite inconvenient.

BTW, should we add C-n and friends to org-navigation-repeat-map or just
have n, p, etc.?  I personally find C-n in the repeat-map disruptive
since I usually want to move the cursor after jumping to a specific
heading, in which case C-n not being next-line is annoying.