[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Inline image display as part of a new org-link-preview sy
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH v3] Inline image display as part of a new org-link-preview system |
Date: |
Tue, 10 Sep 2024 18:34:19 +0000 |
Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
>>> since the previews are place asynchronously. It always reports "no
>>> images to display inline". Should I remove this messaging, or find a
>>> way to run this from the final async chunk? The code gets a little
>>> convoluted when I do the latter.
>>
>> I am a bit confused. Isn't `org-link-preview--get-overlays' counting
>> overlays? And the overlays should be created before async preview is
>> complete, right? Or do I miss something?
>
> Currently I only add the overlay to `org-link-preview-overlays' if/when
> the preview is successful. `org-link-preview--get-overlays' counts
> overlays in this buffer-local list.
> ...
Ok.
The idea behind that message is mostly to make user aware if there are
any/none images to be actually displayed. It does not have to count
actual overlays.
Instead, we may display something like "X images _will_ be displayed..."
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, (continued)
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/09
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/09
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/09
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/09
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/10
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/10
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/15
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/09
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/10
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/10
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system,
Ihor Radchenko <=
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/10
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/15
- Re: [PATCH v3] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/15
- Re: [PATCH v4] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/15
- Re: [PATCH v4] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/17
- Re: [PATCH v5] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/17
- Re: [PATCH v5] Inline image display as part of a new org-link-preview system, Ihor Radchenko, 2024/09/21
- Re: [PATCH v6] Inline image display as part of a new org-link-preview system, Karthik Chikmagalur, 2024/09/22