Re: [BUG] export blocks no longer fontifying [9.7.10 (release_9.7.10 @ /Users/ben/Scripts/emacs/lisp/org/)]

[Ihor Radchenko]

Benjamin McMillan <mcmillanbb@gmail.com> writes:

> I attach the patch here.

Thanks!

> However, I have two questions.
> First, I am not certain that I set up the repository correctly, because
> when I run "make test" it generates 55 unexpected failures. This without
> making any changes.
> (The patch submitted here does not generate any new failures.)

That's odd. May you share the log?

> Second, the existing comment at the patch becomes slightly out of date with
> the change.

Then, may you please update the comment?

Also, may you change the commit message to not sound like it is a new
feature? Just explain the purpose of the change as you did in this
email thread (but shorter, and then add a link to this thread).

> In fact, I propose that it might be good to update the docstring for
> `org-src-fontify-natively' to explicitly state that it enable fontification
> for src, example, and export blocks.

I'd rather not document this in `org-src-fontify-natively'. The name of
this variable does not really hint that it has anything to do with
export or example blocks.

We may eventually rename it to something more generic, but example
blocks may need to be re-considered because specifying language of the
example block is not even a part of Org syntax. So, generalizing and
documenting this is a bit tricky.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>