emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unexpected error using org-gnus-follow-link


From: Visuwesh
Subject: Re: Unexpected error using org-gnus-follow-link
Date: Thu, 26 Dec 2024 18:20:41 +0530
User-agent: Gnus/5.13 (Gnus v5.13)

[திங்கள் டிசம்பர் 23, 2024] Ihor Radchenko wrote:

> Visuwesh <visuweshm@gmail.com> writes:
>
>>> Do you want to make a patch to that effect?
>>
>> How about the attached?  It falls back to the default value if the key
>> is not found in the alist.
>
> I'd rather just throw an error. If the value is not right in the
> customization, the user likely tried to customize things but failed to
> follow the value format. Falling back in such situation will create a
> headache "why Org is doing not what I tell Org to do?".
>
> Also, (cdr (assq 'gnus org-link-frame-setup)) = nil is not the only
> possible incorrect customization. I'd rather check if the cdr is a
> function and throw a descriptive error otherwise asking to fix
> `org-link-frame-setup'.

How about the attached?

BTW, I hope the function would not erroneously signal an error when the
frame setup function isn't yet loaded because of the fboundp check (but
I guess the chances of that are quite slim).

Attachment: 0001-Error-if-org-link-frame-setup-is-ill-defined.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]