|
From: | Max Nikulin |
Subject: | Re: [PATCH v2] org-protocol: Add void() to bookmarklets |
Date: | Fri, 27 Dec 2024 23:48:37 +0700 |
User-agent: | Mozilla Thunderbird |
On 24/12/2024 21:23, Ihor Radchenko wrote:
Max Nikulin writes:javascript:location.href='org-protocol://store-link?'+new URLSearchParams({url:location.href, title:document.title}); void(0);If you think that ";void(0)" variant is less prone to errors then I may update my patch. I have no idea if balanced void(...) parenthesis around the whole expressions would cause more user mistakes. Otherwise both variants are equivalent.Then, no need to change your variant.
I changed the patch to trailing ";void(0)" and I have found a typo in first variant of the patch.
Should ORG-NEWS be updated as well?
I have realized that an example in ORG-NEWS is incomplete and so it does not require update.
I consider the change as a minor fix that does not deserves loud announcement, especially taking into account that browsers discourages protocol handlers launched on behalf of web pages nowadays.
[...]
In this case, it is a good idea for users of the previously suggested bookmarklet to update to the new version. This way, they will be less likely to meet breakage one day when they decide to upgrade Firefox.
Users do not decide when they update a major browser. Security fixes arrive at least once a month or even more often. This particular change has been backported to the ESR channel, so it is too late to notify users through ORG-NEWS.
I have had a look into Firefox bug tracker. Behavior in respect to external protocol handlers has changed during a couple of years. Some of latest issues are not public.
v2-0001-org-protocol-Add-void-0-to-bookmarklets.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |