[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [calendar] Holidays menu doesn't go away

From: Stefan Monnier
Subject: Re: [calendar] Holidays menu doesn't go away
Date: Sat, 22 Mar 2003 17:30:41 -0500

> > The logentry explains why:
> >
> >     * emacs-lisp/easymenu.el (easy-menu-name-match): Catch any error
> >     that member-ignore-case might signal.
> >     (easy-menu-add-item): Default to the global map, as documented.
> >     (easy-menu-convert-item-1): Use match-string.
> >
> > As for where it's documented: in the docstring a few lines above.
> > So recentf should probably not use a nil MAP if it wants to use
> > the local map.
> > Or should we change the doc instead ?
> The change to `easy-menu-add-item' causes trouble with info and
> calendar, and also with external libraries like emacs-w3m.  Reversion
> superficially avoids that trouble, but I don't really grok easymenu.
> Maybe it is easier to change the doc instead if there are many callers
> to fix.

I've been looking at what the XEmacs version does (since compatibility
is the whole point of easymenu) and there a nil MAP (which they call
MENU) means "use the current menu" which actually means use the menu
in the `current-menubar' which can be made a buffer-local variable,
but not necessarily.
Admittedly, it is almost always buffer-local, so I think you're
right that it's better to change the docstring and revert my patch
to the code.

But then it seems that easy-menu offers no way to portably add
a global menu.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]