Re: Bad interaction between set-fringe-style and set-window-fringes.

[Lute Kamstra]

address@hidden (Kim F. Storm) writes:

>> What about the patch below?
>
> That's ok with me ...
>
> .. but, I don't see it mentions how it differs from set-window-fringes :-)

It mentions that it sets default widths, but I should probably make it
a little bit more explicit.  What about the patch below instead?  It
changes the docstring of set-window-fringes as well.

  Lute.


Index: lisp/fringe.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/fringe.el,v
retrieving revision 1.6
diff -c -r1.6 fringe.el
*** lisp/fringe.el      1 Sep 2003 15:45:12 -0000       1.6
--- lisp/fringe.el      13 Oct 2003 13:52:50 -0000
***************
*** 139,166 ****
  
  ;;;###autoload
  (defun fringe-mode (&optional mode)
!   "Toggle appearance of fringes on all frames.
! Valid values for MODE include `none', `default', `left-only',
! `right-only', `minimal' and `half'.  MODE can also be a cons cell
! where the integer in car will be used as left fringe width and the
! integer in cdr will be used as right fringe width. If MODE is not
! specified, the user is queried.
! It applies to all frames that exist and frames to be created in the
! future.
! If you want to set appearance of fringes on the selected frame only,
! see `set-fringe-style'."
    (interactive (list (fringe-query-style 'all-frames)))
    (set-fringe-mode mode))
  
  ;;;###autoload
  (defun set-fringe-style (&optional mode)
!   "Set appearance of fringes on selected frame.
! Valid values for MODE include `none', `default', `left-only',
! `right-only', `minimal' and `half'.  MODE can also be a cons cell
! where the integer in car will be used as left fringe width and the
! integer in cdr will be used as right fringe width. If MODE is not
! specified, the user is queried.
! If you want to set appearance of fringes on all frames, see `fringe-mode'."
    (interactive (list (fringe-query-style)))
    (modify-frame-parameters
     (selected-frame)
--- 139,190 ----
  
  ;;;###autoload
  (defun fringe-mode (&optional mode)
!   "Set default appearance of fringes on all frames.
! 
! When called interactively, the user is queried for MODE.  Valid
! values for MODE include `none', `default', `left-only',
! `right-only', `minimal' and `half'.
! 
! When used in a Lisp program, MODE can be a cons cell where the
! integer in car specifies the left fringe width and the integer in
! cdr specifies the right fringe width.  MODE can also be a single
! integer that specifies both the left and the right fringe width.
! When nil is used instead of an integer, that means to use the
! default fringe width (8 pixels).  These width specifications may
! be rounded up to ensure that their sum is a multiple of the
! character width of a frame.  A fringe width of 0 is never rounded
! up.
! 
! Fringe widths set by `set-window-fringes' override the default
! fringe widths set by this command.  This command applies to all
! frames that exist and frames to be created in the future.  If you
! want to set the default appearance of fringes on the selected
! frame only, see the command `set-fringe-style'."
    (interactive (list (fringe-query-style 'all-frames)))
    (set-fringe-mode mode))
  
  ;;;###autoload
  (defun set-fringe-style (&optional mode)
!   "Set default appearance of fringes on selected frame.
! 
! When called interactively, the user is queried for MODE.  Valid
! values for MODE include `none', `default', `left-only',
! `right-only', `minimal' and `half'.
! 
! When used in a Lisp program, MODE can be a cons cell where the
! integer in car specifies the left fringe width and the integer in
! cdr specifies the right fringe width.  MODE can also be a single
! integer that specifies both the left and the right fringe width.
! When nil is used instead of an integer, that means to use the
! default fringe width (8 pixels).  These width specifications may
! be rounded up to ensure that their sum is a multiple of the
! character width of the frame.  A fringe width of 0 is never
! rounded up.
! 
! Fringe widths set by `set-window-fringes' override the default
! fringe widths set by this command.  If you want to set the
! default appearance of fringes on all frames, see the command
! `fringe-mode'."
    (interactive (list (fringe-query-style)))
    (modify-frame-parameters
     (selected-frame)
Index: src/window.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/window.c,v
retrieving revision 1.450
diff -c -r1.450 window.c
*** src/window.c        11 Oct 2003 23:03:09 -0000      1.450
--- src/window.c        13 Oct 2003 13:52:51 -0000
***************
*** 5925,5931 ****
  the right fringe.  Fourth parameter OUTSIDE-MARGINS non-nil specifies
  that fringes are drawn outside of the display margins; by default, fringes
  are drawn between display marginal areas and the text area.
! A nil width parameter means to use the frame's corresponding fringe width.  
*/)
       (window, left, right, outside_margins)
       Lisp_Object window, left, right, outside_margins;
  {
--- 5925,5932 ----
  the right fringe.  Fourth parameter OUTSIDE-MARGINS non-nil specifies
  that fringes are drawn outside of the display margins; by default, fringes
  are drawn between display marginal areas and the text area.
! A nil width parameter means to use the frame's default fringe width;
! default fringe widths can be set with the command `set-fringe-style'. */)
       (window, left, right, outside_margins)
       Lisp_Object window, left, right, outside_margins;
  {