strokes.el changes

[Dave Love]

This change allows you to use strokes more sensibly as an input method
and makes listing the strokes work on a black background.

A suitable NEWS entry might be:

New command `strokes-global-set-stroke-string' is like
`strokes-global-set-stroke', but it allows you to bind the stroke
directly to a string to insert.  This is convenient for using strokes
as an input method.

2004-03-16  Dave Love  <address@hidden>

        * strokes.el (strokes-global-set-stroke-string): New.
        (strokes-list-strokes): Cope with strings, not just commands.  Set
        foreground colour of image.

Index: strokes.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/strokes.el,v
retrieving revision 1.16
diff -u -p -r1.16 strokes.el
--- strokes.el  6 Oct 2003 16:33:13 -0000       1.16
+++ strokes.el  26 Mar 2004 12:33:58 -0000
@@ -78,7 +78,7 @@
 
 ;;       however, if you would probably just have the user enter in the
 ;;       stroke interactively and then set the stroke to whatever he/she
-;;       entered. The Lisp function to interactively read a stroke is
+;;       entered.  The Lisp function to interactively read a stroke is
 ;;       `strokes-read-stroke'.  This is especially helpful when you're
 ;;       on a fast computer that can handle a 9x9 stroke grid.
 
@@ -435,7 +435,9 @@ or for window START-WINDOW if that is sp
 Operated just like `global-set-key', except for strokes.
 COMMAND is a symbol naming an interactively-callable function.  STROKE
 is a list of sampled positions on the stroke grid as described in the
-documentation for the `strokes-define-stroke' function."
+documentation for the `strokes-define-stroke' function.
+
+See also `strokes-global-set-stroke-string'."
   (interactive
    (list
     (and (or strokes-mode (strokes-mode t))
@@ -444,6 +446,22 @@ documentation for the `strokes-define-st
     (read-command "Command to map stroke to: ")))
   (strokes-define-stroke strokes-global-map stroke command))
 
+(defun strokes-global-set-stroke-string (stroke string)
+  "Interactively give STROKE the global binding as STRING.
+Operated just like `global-set-key', except for strokes.  STRING
+is a string to be inserted by the stroke.  STROKE is a list of
+sampled positions on the stroke grid as described in the
+documentation for the `strokes-define-stroke' function.
+
+Compare `strokes-global-set-stroke-string'."
+  (interactive
+   (list
+    (and (or strokes-mode (strokes-mode t))
+        (strokes-read-complex-stroke
+         "Draw with mouse button 1 (or 2).  End with button 3..."))
+    (read-string "String to map stroke to: ")))
+  (strokes-define-stroke strokes-global-map stroke string))
+
 ;;(defun global-unset-stroke (stroke); FINISH THIS DEFUN!
 ;;  "delete all strokes matching STROKE from `strokes-global-map',
 ;; letting the user input
@@ -1319,7 +1337,9 @@ If STROKES-MAP is not given, `strokes-gl
      "-------                                     ------")
     (loop for def in strokes-map do
          (let ((stroke (car def))
-               (command-name (symbol-name (cdr def))))
+               (command-name (if (symbolp (cdr def))
+                                 (symbol-name (cdr def))
+                               (prin1-to-string (cdr def)))))
            (strokes-xpm-for-stroke stroke " *strokes-xpm*")
            (newline 2)
            (insert-char ?\  45)
@@ -1327,9 +1347,13 @@ If STROKES-MAP is not given, `strokes-gl
            (insert command-name)
            (beginning-of-line)
            (forward-char 45)
-           (insert-image (create-image (with-current-buffer " *strokes-xpm*"
-                                         (buffer-string))
-                                       'xpm t)))
+           (insert-image
+            (create-image (with-current-buffer " *strokes-xpm*"
+                            (buffer-string))
+                          'xpm t
+                          :color-symbols
+                          `(("foreground"
+                             . ,(frame-parameter nil 'foreground-color))))))
          finally do (kill-region (1+ (point)) (point-max)))
     (view-buffer "*Strokes List*" nil)
     (set (make-local-variable 'view-mode-map)

2004-03-16  Dave Love  <address@hidden>

        * strokes.el (strokes-global-set-stroke-string): New.
        (strokes-list-strokes): Cope with strings, not just commands.  Set
        foreground colour of image.

Index: strokes.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/strokes.el,v
retrieving revision 1.16
diff -u -p -r1.16 strokes.el
--- strokes.el  6 Oct 2003 16:33:13 -0000       1.16
+++ strokes.el  26 Mar 2004 12:33:58 -0000
@@ -78,7 +78,7 @@
 
 ;;       however, if you would probably just have the user enter in the
 ;;       stroke interactively and then set the stroke to whatever he/she
-;;       entered. The Lisp function to interactively read a stroke is
+;;       entered.  The Lisp function to interactively read a stroke is
 ;;       `strokes-read-stroke'.  This is especially helpful when you're
 ;;       on a fast computer that can handle a 9x9 stroke grid.
 
@@ -435,7 +435,9 @@ or for window START-WINDOW if that is sp
 Operated just like `global-set-key', except for strokes.
 COMMAND is a symbol naming an interactively-callable function.  STROKE
 is a list of sampled positions on the stroke grid as described in the
-documentation for the `strokes-define-stroke' function."
+documentation for the `strokes-define-stroke' function.
+
+See also `strokes-global-set-stroke-string'."
   (interactive
    (list
     (and (or strokes-mode (strokes-mode t))
@@ -444,6 +446,22 @@ documentation for the `strokes-define-st
     (read-command "Command to map stroke to: ")))
   (strokes-define-stroke strokes-global-map stroke command))
 
+(defun strokes-global-set-stroke-string (stroke string)
+  "Interactively give STROKE the global binding as STRING.
+Operated just like `global-set-key', except for strokes.  STRING
+is a string to be inserted by the stroke.  STROKE is a list of
+sampled positions on the stroke grid as described in the
+documentation for the `strokes-define-stroke' function.
+
+Compare `strokes-global-set-stroke'."
+  (interactive
+   (list
+    (and (or strokes-mode (strokes-mode t))
+        (strokes-read-complex-stroke
+         "Draw with mouse button 1 (or 2).  End with button 3..."))
+    (read-string "String to map stroke to: ")))
+  (strokes-define-stroke strokes-global-map stroke string))
+
 ;;(defun global-unset-stroke (stroke); FINISH THIS DEFUN!
 ;;  "delete all strokes matching STROKE from `strokes-global-map',
 ;; letting the user input
@@ -1319,7 +1337,9 @@ If STROKES-MAP is not given, `strokes-gl
      "-------                                     ------")
     (loop for def in strokes-map do
          (let ((stroke (car def))
-               (command-name (symbol-name (cdr def))))
+               (command-name (if (symbolp (cdr def))
+                                 (symbol-name (cdr def))
+                               (prin1-to-string (cdr def)))))
            (strokes-xpm-for-stroke stroke " *strokes-xpm*")
            (newline 2)
            (insert-char ?\  45)
@@ -1327,9 +1347,13 @@ If STROKES-MAP is not given, `strokes-gl
            (insert command-name)
            (beginning-of-line)
            (forward-char 45)
-           (insert-image (create-image (with-current-buffer " *strokes-xpm*"
-                                         (buffer-string))
-                                       'xpm t)))
+           (insert-image
+            (create-image (with-current-buffer " *strokes-xpm*"
+                            (buffer-string))
+                          'xpm t
+                          :color-symbols
+                          `(("foreground"
+                             . ,(frame-parameter nil 'foreground-color))))))
          finally do (kill-region (1+ (point)) (point-max)))
     (view-buffer "*Strokes List*" nil)
     (set (make-local-variable 'view-mode-map)