Re: help-default-arg-highlight

[Miles Bader]

Kenichi Handa <address@hidden> writes:
> ! DEFUN ("internal-char-font", Finternal_char_font, Sinternal_char_font, 1, 
> 3, 0,
> *** 1252,1258 ****
> !       face_id = DEFAULT_FACE_ID;
> --- 1252,1258 ----
> !       face_id = compute_char_face (f, 0, prop);

That seems like a very round-about method of doing it; would something
like the following work?

   /* Return true if the face on frame F described by PROPS differs from the
      default face.  */
   int
   x_face_font_differs_from_default (struct frame *f, Lisp_Object props)
   {
     struct face *face, *def_face;
     Lisp_Object attrs[LFACE_VECTOR_SIZE];

     for (i = 0; i < LFACE_VECTOR_SIZE; i++)
       attrs[i] = Qunspecified;

     merge_face_vector_with_property (f, attrs, props);

     face = FACE_FROM_ID (f, lookup_face (f, attrs, c, NULL));
     def_face = FACE_FROM_ID (f, DEFAULT_FACE_ID);

     /* Should this compare font_name instead?  */
     return face->font != def_face->font;
   }

-Miles
-- 
o The existentialist, not having a pillow, goes everywhere with the book by
  Sullivan, _I am going to spit on your graves_.