[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: standard-diplay-table very broken
From: |
Kim F. Storm |
Subject: |
Re: standard-diplay-table very broken |
Date: |
Thu, 02 Dec 2004 10:42:34 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) |
I looked some more at this change, and there are several problems
with it.
- the code should not set standard-diplay-table unconditionally.
- the code should not use make-display-table which is autoloaded.
- perhaps the code shouldn't be in disp-table.el at all, but
rather in faces.el right after "defface glyph" -- like this:
(or standard-diplay-table
;; avoid using autoloaded make-display-table here
(setq standard-display-table (make-char-table 'display-table nil)))
(let* ((face (lsh (face-id 'glyph) 19))
(backslash (+ face ?\\))
(dot (+ face ?.)))
(set-char-table-extra-slot standard-display-table 2 backslash)
(aset standard-display-table 2208 (vector backslash ?\ ))
(aset standard-display-table 2221 (vector backslash ?-))
(set-char-table-extra-slot standard-display-table 3 (+ face ?^))
(set-char-table-extra-slot standard-display-table 4 (vector dot dot dot)))
- the name of the 'glyph' face is not very good, as it doesn't say anything
about what it's used for. A better name could be 'escape-glyph'.
--
Kim F. Storm <address@hidden> http://www.cua.dk