[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cast problem in code conversion

From: Kenichi Handa
Subject: Re: cast problem in code conversion
Date: Mon, 27 Dec 2004 15:01:00 +0900 (JST)
User-agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/21.3.50 (sparc-sun-solaris2.6) MULE/5.0 (SAKAKI)

In article <address@hidden>, YAMAMOTO Mitsuharu <address@hidden> writes:

> Calculation of the value of `ratio' in `code_convert_region' is
> missing a cast to float.  That makes the result inaccurate.

> In Emacs 21.2, the part in question was as follows:
>         float ratio = coding->produced - coding->consumed;
>         ratio /= coding->consumed;

> But in Emacs 21.3,
>             ratio = (coding->produced - coding->consumed) / coding->consumed;

> Reverting this change drastically improves performance when opening a
> large binary file.  For example, opening the Emacs executable becomes
> 6 times faster for me.

Thank you for finding this bug.  I've just installed a fix.

Ken'ichi HANDA

reply via email to

[Prev in Thread] Current Thread [Next in Thread]