[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Enabling xassert unconditionally causes a problem in xfaces.c.
From: |
Miles Bader |
Subject: |
Re: Enabling xassert unconditionally causes a problem in xfaces.c. |
Date: |
Thu, 3 Feb 2005 20:09:12 +0900 |
On Thu, 03 Feb 2005 11:13:35 +0100, Lute Kamstra
<address@hidden> wrote:
> ngcs is declared behind an #if GLYPH_DEBUG and is used in x_free_gc
> within an xassert. xassert used to be void when GLYPH_DEBUG was not
> set, but the above change enables xassert unconditionally thus causing
> a problem.
>
> Should ngcs be declared unconditionally as well or should its use in
> x_free_gc be put within an IF_DEBUG?
I would declare it unconditionally, and remove the IF_DEBUG around its
use in other places -- it's a very cheap check.
-Miles
--
Do not taunt Happy Fun Ball.