emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: menu-bar-update-hook run very often


From: Ralf Angeli
Subject: Re: menu-bar-update-hook run very often
Date: Mon, 28 Feb 2005 09:10:28 +0100
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)

* Richard Stallman (2005-02-27) writes:

>     The doc string of `menu-bar-update-hook' states that it is a "... hook
>     run for clicks on menu bar, before displaying a submenu."
>
> I think the doc string is mistaken.  Every substantial redisplay runs
> this hook since every substantial redisplay updates the menu bar
> display structures (if the menu bar has changed).  For instance, it
> updates the Buffers submenu if the set of buffers has changed.
>
> I will update the documentation.  Meanwhile, do you think
> the current behavior is a problem?

If people deduct from the current doc string that the hook is only
called when the menubar is used, this could make them disregard
performance issues with the function to be put into the hook.  And it
could slow down Emacs if the function is called very often during
editing.  The changed doc string is not so misleading in this regard.
Thanks for adapting it.

-- 
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]